-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Revise OpenCQRS description in README #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughRewrites README.md to broaden OpenCQRS description: from a .NET Core library with Azure Service Bus and specific databases to a .NET framework for DDD, CQRS, and Event Sourcing, noting mediator or full event-sourcing modes, Cosmos DB or EF Core storage, and built-in integrations (Service Bus, RabbitMQ, Redis Cache, Memory Cache, FluentValidation). Changes
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
README.md (2)
654-654: Tighten the copy and align with list style; avoid marketing phrasing.Single sentence; no “among other features”; consistent commas; use concise separators.
-* [OpenCQRS](https://github.com/OpenCQRS/OpenCQRS) - OpenCQRS is a .NET framework for DDD, CQRS, and Event Sourcing. It can be used as a simple mediator or as a full Event Sourcing solution with Cosmos DB or Entity Framework Core as storage. It has built-in support for Service Bus, RabbitMQ, Redis Cache, Memory Cache, and FluentValidation among other features. +* [OpenCQRS](https://github.com/OpenCQRS/OpenCQRS) - .NET framework for DDD, CQRS, and Event Sourcing; usable as a mediator or a full event-sourcing solution with Cosmos DB or Entity Framework Core storage; built-in support for Service Bus, RabbitMQ, Redis Cache, MemoryCache, and FluentValidation.
654-654: Clarify provider names in README.md (line 654).OpenCQRS documents built-in providers for Azure Service Bus, RabbitMQ, FluentValidation, and both in‑memory and Redis caching — update wording for clarity and .NET naming consistency:
- "Service Bus" → "Azure Service Bus"
- "Rabbit MQ" → "RabbitMQ"
- "Fluent Validation" → "FluentValidation"
- "Redis Cache" → "Redis (Redis Cache provider)"
- "Memory Cache" → "MemoryCache (in‑memory)"
Update description for OpenCQRS
Summary by CodeRabbit