-
Notifications
You must be signed in to change notification settings - Fork 82
✨ Dashboard Account Settings #2310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4-reviews
Are you sure you want to change the base?
Conversation
…s form dirty state
…t conditional visibility for action buttons.
…l width to dashboard header.
…lexible attachment card, and updated input field requirements.
…ignature uploader to single image type
Refactored the register method to better handle checkbox and file input types, set appropriate default values, and simplified the binding logic for Alpine.js. This enhances support for different input types and improves code clarity.
Moved and renamed profile-header.php to account/settings/header.php and updated references. Deleted obsolete profile-settings.php. Refactored billing address, notifications, preferences, and social accounts templates to use new InputField components, improved form state management, and enhanced UI consistency.
Enhanced the user social icons array by adding 'svg_icon' and 'pattern' fields for Facebook, X (Twitter), LinkedIn, GitHub, and Website. This provides SVG icon references and URL validation patterns for each social profile, improving consistency and validation.
Introduced a dropdown for selecting font size in account preferences, replacing the text input. Added predefined font size options and updated default value handling. Also improved select component styling for better UI consistency.
Introduced User::get_profile_settings_data() to centralize and streamline retrieval of user profile data for the account settings form. Updated the account settings template to use this method, improved default value handling, and switched display name and bio fields to use select and textarea input types, respectively.
Replaced the JavaScript history back button with a server-generated back URL using UrlHelper in the account settings header. Updated the close button to use the same back URL and improved responsive visibility classes. Minor SCSS formatting adjustments for consistency.
The add_action call for 'wp_enqueue_scripts' no longer specifies PHP_INT_MAX as the priority, reverting to the default priority. This may affect the order in which scripts are enqueued.
| @include tutor-typography('tiny', 'regular', 'secondary', 'body'); | ||
| } | ||
|
|
||
| &-actions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removed? there is a action button the to attachement card.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class is not used in the template.
…ate loads for attachment cards.
…e limits, and WordPress media integration.
…minating page reloads and updating field default values.
| * | ||
| * @since 4.0.0 | ||
| */ | ||
| class AttachmentCard extends BaseComponent { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add examples of usage on the class doc comment.
| * | ||
| * @since 4.0.0 | ||
| */ | ||
| class FileUploader extends BaseComponent { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add usage examples
| * | ||
| * @since 4.0.0 | ||
| * | ||
| * @param string $accept Accept attribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the accepted types on this comment.
| <?php | ||
| Button::make() | ||
| ->label( __( 'Upload Photo', 'tutor' ) ) | ||
| ->variant( Variant::PRIMARY ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default variant is primary not need to pass.
| <?php | ||
| Button::make() | ||
| ->label( __( 'Upload Photo', 'tutor' ) ) | ||
| ->variant( Variant::PRIMARY ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
✨ Update asset enqueuing with calendar dashboard
|
|
||
| Button::make() | ||
| ->label( __( 'Save', 'tutor' ) ) | ||
| ->variant( Variant::PRIMARY ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same here
…e uploader attachment card meta.
…version and WP Media integration.
…nts, and streamline button component usage by removing redundant primary variant calls.
This PR includes
New/Enhanced feature
-instead of double--incardscssget_profile_settings_datafunction toUserclass