ASoC: sdw_utils: remove dai registered check #5629
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@charleskeepax Can you remind me why we added the DAI registered check? I vaguely remember below code could return error in a few corner cases. But I can't remember which cases are they. sdw_dev = bus_find_device_by_name(&sdw_bus_type, NULL, sdw_codec_name);
if (!sdw_dev) {
dev_err(dev, "codec %s not found\n", sdw_codec_name);
return -EINVAL;
}
slave = dev_to_sdw_dev(sdw_dev);
if (!slave) {
ret = -EINVAL;
goto put_device;
}I tested on my ARL + cs42l43 device and blocked list the snd_soc_cs42l43 module and load it later and it seems work fine. |
ujfalusi
approved these changes
Dec 29, 2025
ranj063
reviewed
Dec 29, 2025
| const struct snd_soc_acpi_adr_device *adr_dev = &adr_link->adr_d[adr_index]; | ||
| const struct snd_soc_acpi_endpoint *adr_end; | ||
| const struct asoc_sdw_dai_info *dai_info; | ||
| struct snd_soc_dai_link_component *dlc; |
Collaborator
There was a problem hiding this comment.
@bardliao Can we drop the first sentence in the commit message and say that checking for a registered DAI for non-existing endpoints causes the following error and state the error here?
Checking for a registered DAI for non-existing endpoints causes the following error. The driver will always return -EPROBE_DEFER if the codec driver doesn't register the DAI of the unexist endpoint. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
remove-dai-check
branch
from
0493cf6 to
37e5b46
Compare
bardliao
requested review from
dbaluta,
kv2019i,
lgirdwood and
plbossart
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, we check if the DAI is registered before checking the endpoint is present. It will cause problem if the codec driver doesn't register the DAI of the unexist endpoint.