Skip to content

Modular Wallet Types #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
d4mr wants to merge 9 commits into from
Closed

Modular Wallet Types #834

d4mr wants to merge 9 commits into from

Conversation

@d4mr
Copy link
Contributor

@d4mr d4mr commented Jan 22, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on migrating the project from yarn to pnpm for package management, alongside various code refactors and improvements in wallet handling and configuration management.

Detailed summary

  • Removed yarn configuration files and yarn.lock.
  • Updated CI workflows to use pnpm instead of yarn.
  • Refactored decrypt functions to enhance password handling.
  • Introduced walletProviderCredentialsSchema for better credential management.
  • Reorganized wallet-related imports and paths.
  • Added new CircleCredential schema for Circle wallet integration.
  • Implemented AWS and GCP KMS plugins with improved credential handling.
  • Enhanced database schema for wallet credentials and configurations.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

joaquim-verges
joaquim-verges reviewed Jan 23, 2025
View reviewed changes
src/shared/lib/accounts/account-service.ts Outdated

// type WalletType =
// | (typeof ACCOUNT_PLUGINS)[number]["type"]
// | `smart:${(typeof ACCOUNT_PLUGINS)[number]["type"]}`;
Copy link
Member

@joaquim-verges joaquim-verges Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup

joaquim-verges
joaquim-verges reviewed Jan 23, 2025
View reviewed changes
src/shared/lib/accounts/plugins/aws-kms/index.ts
const awsKmsArn = res.KeyMetadata.Arn;
const { keyId } = splitAwsKmsArn(awsKmsArn);

const account = await getAwsKmsAccount({
Copy link
Member

@joaquim-verges joaquim-verges Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one day you should extract this into the sdk :D

joaquim-verges
joaquim-verges reviewed Jan 23, 2025
View reviewed changes
src/shared/lib/accounts/plugins/aws-kms/index.ts
type AwsKmsCredential = z.infer<typeof awsKmsCredentialSchema>;

// AWS KMS Plugin Definition
export const awsKmsPlugin = defineAccountPlugin({
Copy link
Member

@joaquim-verges joaquim-verges Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was expecting to see a plugin for GCP and one for private key as well? is it just not implemented yet?

Copy link
Contributor Author

@d4mr d4mr Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, need to extract the exiting code into this plugin format. Will also be adding one for circle

@github-actions
Copy link

github-actions bot commented Jan 31, 2025

This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days.

@socket-security
Copy link

socket-security bot commented Jan 31, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/client-kms@3.734.0 🔁 npm/@aws-sdk/client-kms@3.709.0 Transitive: environment, filesystem, network +71 5.57 MB aws-sdk-bot
npm/@babel/preset-typescript@7.26.0 🔁 npm/@babel/preset-typescript@7.23.2 Transitive: environment, filesystem, shell +28 5.54 MB nicolo-ribaudo
npm/@preconstruct/cli@2.8.10 🔁 npm/@preconstruct/cli@2.8.1 Transitive: environment, eval, filesystem, shell, unsafe +78 16.3 MB preconstruct-release-bot
npm/@types/jsonwebtoken@9.0.8 🔁 npm/@types/jsonwebtoken@9.0.7 None +1 18.8 kB types
npm/@types/node@18.19.74 🔁 npm/@types/node@20.8.9, npm/@types/node@22.10.2 None +1 2.12 MB types
npm/@types/pg@8.11.11 🔁 npm/@types/pg@8.11.10 None +10 288 kB types
npm/@types/ws@8.5.14 🔁 npm/@types/ws@8.5.13 None 0 38.8 kB types
npm/bullmq@5.37.0 🔁 npm/bullmq@5.34.0 environment, filesystem, network, shell Transitive: eval, unsafe +4 4.08 MB manast
npm/dd-trace@5.32.0 🔁 npm/dd-trace@5.28.0 None +55 92.3 MB datadog
npm/ioredis@5.4.2 🔁 npm/ioredis@5.4.1 Transitive: environment +9 911 kB ioredis-robot
npm/thirdweb@5.86.3 🔁 npm/thirdweb@5.87.2 Transitive: environment, eval, filesystem, shell, unsafe +318 175 MB thirdweb-bot
npm/typescript@5.7.3 🔁 npm/typescript@5.7.2 None 0 22.7 MB typescript-bot
npm/viem@2.22.15 🔁 npm/viem@2.22.17 network Transitive: environment +11 25.2 MB jmoxey

🚮 Removed packages: npm/@ampproject/remapping@2.2.1, npm/@aws-sdk/client-sso-oidc@3.709.0, npm/@aws-sdk/client-sts@3.709.0, npm/@babel/code-frame@7.22.13, npm/@babel/helper-function-name@7.23.0, npm/@babel/helper-hoist-variables@7.22.5, npm/@babel/helper-module-imports@7.22.15, npm/@babel/helper-simple-access@7.22.5, npm/@babel/helper-split-export-declaration@7.22.6, npm/@babel/helper-string-parser@7.22.5, npm/@babel/helper-validator-identifier@7.22.20, npm/@babel/highlight@7.22.20, npm/@babel/template@7.22.15, npm/@jridgewell/resolve-uri@3.1.1, npm/@jridgewell/set-array@1.1.2, npm/@jridgewell/sourcemap-codec@1.4.15, npm/@parcel/watcher-android-arm64@2.5.0, npm/@parcel/watcher-darwin-arm64@2.5.0, npm/@parcel/watcher-darwin-x64@2.5.0, npm/@parcel/watcher-freebsd-x64@2.5.0, npm/@parcel/watcher-linux-arm-glibc@2.5.0, npm/@parcel/watcher-linux-arm-musl@2.5.0, npm/@parcel/watcher-linux-arm64-glibc@2.5.0, npm/@parcel/watcher-linux-arm64-musl@2.5.0, npm/@parcel/watcher-linux-x64-glibc@2.5.0, npm/@parcel/watcher-linux-x64-musl@2.5.0, npm/@parcel/watcher-wasm@2.5.0, npm/@parcel/watcher-win32-arm64@2.5.0, npm/@parcel/watcher-win32-ia32@2.5.0, npm/@parcel/watcher-win32-x64@2.5.0, npm/@parcel/watcher@2.5.0, npm/@types/estree@1.0.3, npm/@types/minimist@1.2.4, npm/@types/normalize-package-data@2.4.3, npm/acorn@8.11.2, npm/ansi-styles@3.2.1, npm/arrify@1.0.1, npm/camelcase-keys@6.2.2, npm/chalk@2.4.2, npm/citty@0.1.6, npm/clipboardy@4.0.0, npm/confbox@0.1.8, npm/decamelize-keys@1.1.1, npm/detect-libc@1.0.3, npm/escalade@3.1.1, npm/escape-string-regexp@1.0.5, npm/event-lite@0.1.3, npm/execa@8.0.1, npm/get-port-please@3.1.2, npm/get-stream@8.0.1, npm/hard-rejection@2.1.0, npm/has-flag@3.0.0, npm/hasown@2.0.0, npm/hosted-git-info@2.8.9, npm/http-shutdown@1.2.2, npm/human-signals@5.0.0, npm/indent-string@4.0.0, npm/int64-buffer@0.1.10, npm/invariant@2.2.4, npm/is-ci@2.0.0, npm/is-docker@3.0.0, npm/is-inside-container@1.0.0, npm/is-plain-obj@1.1.0, npm/is-wsl@3.1.0, npm/is64bit@2.0.0, npm/jiti@2.4.1, npm/jsesc@2.5.2, npm/kind-of@6.0.3, npm/listhen@1.9.0, npm/map-obj@4.3.0, npm/meow@7.1.1, npm/mimic-fn@4.0.0, npm/min-indent@1.0.1, npm/minimist-options@4.1.0, npm/mlly@1.7.3, npm/msgpack-lite@0.1.26, npm/napi-wasm@1.1.3, npm/normalize-package-data@2.5.0, npm/npm-run-path@5.3.0, npm/onetime@6.0.0, npm/picocolors@1.0.0, npm/pkg-types@1.2.1, npm/react-remove-scroll-bar@2.3.6, npm/react-style-singleton@2.2.1, npm/read-pkg-up@7.0.1, npm/read-pkg@5.2.0, npm/redent@3.0.0, npm/regenerator-runtime@0.14.0, npm/spdx-correct@3.2.0, npm/spdx-exceptions@2.3.0, npm/spdx-expression-parse@3.0.1, npm/spdx-license-ids@3.0.16, npm/string-width-cjs@4.2.3, npm/strip-ansi-cjs@6.0.1, npm/strip-final-newline@3.0.0, npm/strip-indent@3.0.0, npm/supports-color@5.5.0, npm/system-architecture@0.1.0, npm/to-fast-properties@2.0.0, npm/trim-newlines@3.0.1, npm/type-fest@0.13.1, npm/undici-types@6.20.0, npm/universalify@2.0.0, npm/untun@0.1.3, npm/use-callback-ref@1.3.2, npm/use-sidecar@1.1.2, npm/validate-npm-package-license@3.0.4, npm/webauthn-p256@0.0.10, npm/wrap-ansi-cjs@7.0.0, npm/zod@3.22.4

View full report↗︎

@github-actions
Copy link

github-actions bot commented Feb 9, 2025

This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days.

@github-actions github-actions bot closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges left review comments

Assignees

No one assigned

Labels

no-pr-activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d4mr @joaquim-verges