Skip to content

Conversation

@YiniXu9506
Copy link
Contributor

What is changed?

Update iframe embed method to show full interactive chart generated by google sheet.

Any related PRs or issues?

Which version does your change affect?

Copy link
Member

@iosmanthus iosmanthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Collaborator

please add sign-off

Signed-off-by: YiniXu9506 <xuyini@pingcap.com>
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user from china may not access to google.com

Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user from china may not access to google.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants