perf: lazy import PIL in nes.py and jpeg.py #3441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESultanik
force-pushed
the
perf/lazy-pil-import
branch
2 times, most recently
from
800b0d4 to
b0ac558
Compare
Move PIL imports from module-level to function-level, so PIL is only loaded when actually parsing NES ROMs (nes.py) or JPEG2000 images (jpeg.py). Most files analyzed by PolyFile don't require PIL. Performance improvement: - Import time: 4246ms → 358ms (92% faster) The PIL library takes ~2s to import due to loading many image codec modules. Deferring this import until needed dramatically reduces startup time for the common case. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ESultanik
force-pushed
the
perf/lazy-pil-import
branch
from
b0ac558 to
9d6c04d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nes.pyandjpeg.pyPerformance Results
Test plan
pytest tests/test_magic.py tests/test_pdf.py- same test results as baselineimport polyfile🤖 Generated with Claude Code