perf: lazy import pdfminer in pdf.py #3442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESultanik
force-pushed
the
perf/lazy-pdfminer-import
branch
2 times, most recently
from
9a6022b to
795e25a
Compare
Defer importing the pdf module (and pdfminer) until a PDF file is actually matched. This is done via a lazy parser wrapper that registers immediately but only imports the actual pdf module on first use. The pdfminer library imports many submodules (cryptography, etc.) which adds ~0.5s to import time. Most files aren't PDFs, so deferring this import improves startup time for the common case. Performance improvement: - pdfminer no longer loaded at import time - Import time reduced by ~28% (measured 527ms → 380ms in cached runs) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ESultanik
force-pushed
the
perf/lazy-pdfminer-import
branch
from
795e25a to
8db8471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_LazyPDFParser) that registers immediately but only importspdf.pyon first useImplementation
_LazyPDFParserclass in__init__.pythat wraps the actual PDF parser@register_parserdecorator frompdf.py(registration is now done lazily in__init__.py)Performance Results
Test plan
pytest tests/test_magic.py tests/test_pdf.py- same test results as baselineimport polyfile🤖 Generated with Claude Code