Skip to content

Add Insufficient Balance and Transfer to Zero Address Checks with Gas Optimization #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AayushJhaAudits wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Insufficient Balance and Transfer to Zero Address Checks with Gas Optimization #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions src/tokens/ERC20.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,20 +73,23 @@ abstract contract ERC20 {
return true;
}

function transfer(address to, uint256 amount) public virtual returns (bool) {
balanceOf[msg.sender] -= amount;

// Cannot overflow because the sum of all user
// balances can't exceed the max uint256 value.
unchecked {
balanceOf[to] += amount;
}
error InsufficientBalance();
error TransferToZeroAddress();

emit Transfer(msg.sender, to, amount);
function transfer(address to, uint256 amount) public returns (bool) {
if (balanceOf[msg.sender] < amount) revert InsufficientBalance();
if (to == address(0)) revert TransferToZeroAddress();

return true;
unchecked {
balanceOf[msg.sender] -= amount;
balanceOf[to] += amount;
}

emit Transfer(msg.sender, to, amount);
return true;
}


function transferFrom(
address from,
address to,
Expand Down