feat(source/gitlab): support glob patterns in repositories field #4581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustansir14
reviewed
Dec 8, 2025
Comment on lines
+1031
to
+1038
| // resolveRepositories determines which repositories to scan based on s.repos configuration. | ||
| // It handles three cases: | ||
| // 1. Glob patterns (e.g., "org/*"): enumerates all projects and filters using patterns | ||
| // 2. Explicit URLs: normalizes and reports directly without enumeration | ||
| // 3. Empty: enumerates all projects using includeRepos/ignoreRepos filters | ||
| // | ||
| // All discovered repositories are reported via reporter.UnitOk(). | ||
| func (s *Source) resolveRepositories( |
Contributor
There was a problem hiding this comment.
Looking at the implementation for includeRepos, it looks pretty straightforward where we directly pass in the s.includeRepos slice to buildIgnorer. Why can't we do the same with repos? Why do we need to handle all these cases separately? Is there any context I'm missing here?
Contributor
Author
There was a problem hiding this comment.
Good question! Here's what I've understood since working on this:
includeRepos:
- Always a filter on enumerated projects
- Assumes you're scanning "everything with filters"
- Always calls listProjects() then filters results
repos:
- Can be explicit URLs OR glob patterns
- Supports 3 distinct modes:
a. Explicit URLs only - Use directly, no enumeration needed
b. Glob patterns - Enumerate projects and filter
c. Mixed - Enumerate for globs, use explicit URLs directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for glob patterns in the repositories field, allowing flexible repository matching alongside explicit URLs. Refactors repository resolution logic into resolveRepositories() to eliminate duplication between Chunks() and Enumerate(), improving maintainability and consistency.
Checklist:
make test-community)?make lintthis requires golangci-lint)?