Fix issues with electrical panel upgrade cost assignment and add unit test #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jtlangevin
commented
Jan 15, 2026
jtlangevin
commented
- Correct issues identified in Issues with electrical panel upgrade cost assignment #575.
- Add a unit test that ensures panel upgrade costs are properly assessed in accordance with user settings (Unit test for panel upgrade cost adjustment #569).
- Ensure that shares of homes requiring a panel upgrade are actually assessed when that option is provided. - Remove any dependencies of cost data pre-incentives on subsequent incentive calculations. - Handle primary/secondary keys for fuel type when pulling in panel upgrade shares data. - Ensure that linked cooling equipment costs are properly assigned when processing a panel upgrade subsegment/technology name.
The unit test ensures that settings for panel upgrade share calculations are correctly read in and translated through the fill_mkts function to the measure's output data.
This was
linked to
issues
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.