Skip to content

Conversation

@thelovekesh
Copy link
Collaborator

wpm registry generates signatures for package payloads while publishing new packages. this PR aims to leverage those signatures to verify the tarballs installations.

at the moment, we use plain api call over https to fetch the public keys, but this will be replaced by TUF repo in the future to distribute the public keys.

@thelovekesh thelovekesh added the core changes made in cli core api label Jan 18, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @thelovekesh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the security posture of the package manager by integrating digital signature validation into the package installation process. By verifying the integrity and authenticity of package tarballs against cryptographic signatures, it mitigates risks associated with tampered or malicious packages, ensuring that only trusted software is installed.

Highlights

  • Signature Validation Implementation: Introduced signature validation for package installations, leveraging signatures generated during package publishing by the wpm registry.
  • New Signatures Package: A new signatures package was added, providing the core logic for ECDSA signature verification using public keys.
  • Installer Integration: The Installer now fetches public keys from the registry and utilizes them to verify package tarballs before proceeding with installation.
  • Registry Client Update: The registry.Client interface and its implementation were extended with a new method, GetKeysJson, to retrieve public keys from the registry.
  • Manifest Structure Enhancement: The manifest.Dist structure was updated to include a Signatures field, allowing package manifests to carry signature information.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an important security feature: signature validation for package installations. The implementation correctly introduces new components for fetching public keys and verifying signatures. My review focuses on improving context propagation for cancellable requests, making the signature verification logic more robust by handling multiple signatures, and ensuring consistency in error handling. Overall, these are great changes that significantly improve the security of the package manager.

@github-actions
Copy link

📦 wpm cli builds 📦

@thelovekesh thelovekesh merged commit 2cd74d7 into main Jan 18, 2026
15 checks passed
@thelovekesh thelovekesh deleted the add/signature-validation branch January 18, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core changes made in cli core api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants