-
Notifications
You must be signed in to change notification settings - Fork 1
Add signature validation on package installation #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @thelovekesh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the security posture of the package manager by integrating digital signature validation into the package installation process. By verifying the integrity and authenticity of package tarballs against cryptographic signatures, it mitigates risks associated with tampered or malicious packages, ensuring that only trusted software is installed. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an important security feature: signature validation for package installations. The implementation correctly introduces new components for fetching public keys and verifying signatures. My review focuses on improving context propagation for cancellable requests, making the signature verification logic more robust by handling multiple signatures, and ensuring consistency in error handling. Overall, these are great changes that significantly improve the security of the package manager.
wpm registry generates signatures for package payloads while publishing new packages. this PR aims to leverage those signatures to verify the tarballs installations.
at the moment, we use plain api call over https to fetch the public keys, but this will be replaced by TUF repo in the future to distribute the public keys.