Fix terminal streaming to bail if progress bar not enabled

[thelovekesh]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @thelovekesh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes terminal output streaming by ensuring that the system only attempts to stream data when a progress indicator is explicitly active. This change prevents redundant processing and improves efficiency in environments where visual progress feedback is not required, leading to a cleaner and more performant execution flow.

Highlights

• Terminal Streaming Optimization: Introduced a conditional check within the Stream method in pkg/progress/progress.go to immediately return if the progress indicator is not enabled, preventing unnecessary streaming operations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to prevent terminal streaming operations when the progress bar is not enabled. The change correctly adds a check for p.ProgressIndicatorEnabled in the Stream function. However, the current implementation completely suppresses output when the progress indicator is disabled, which could lead to lost information. I've suggested a modification to ensure that the output is still written to the stream, but without the terminal-specific formatting used for the progress indicator.

[github-actions]

📦 wpm cli builds 📦

• darwin/amd64 - build
• darwin/arm64 - build
• linux/amd64 - build
• linux/arm/v6 - build
• linux/arm/v7 - build
• linux/arm64 - build
• linux/ppc64le - build
• linux/riscv64 - build
• linux/s390x - build
• windows/amd64 - build
• windows/arm64 - build