feature: enable agent edit #23
Merged
+399
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds agent editing functionality to the finchctl tool by introducing a new UpdateAgent gRPC endpoint and corresponding CLI command. The feature allows users to modify configuration settings for already-registered agents.
- Added new
UpdateAgentRPC method to the proto API definition with request/response message types - Implemented
editAgentfunction in the internal agent package to call the gRPC endpoint - Created new
editCLI command with flags for modifying agent configuration (logs, metrics, profiles, labels)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/api/api.proto | Removed copyright header (appropriate for proto definitions) and added UpdateAgent RPC method with UpdateAgentRequest/UpdateAgentResponse messages |
| internal/api/api.pb.go | Auto-generated protobuf code updated with UpdateAgentRequest and UpdateAgentResponse types (copyright header removed as expected for generated code) |
| internal/api/api_grpc.pb.go | Auto-generated gRPC service code updated to include UpdateAgent client and server methods (copyright header removed as expected for generated code) |
| internal/agent/edit.go | New file implementing editAgent function to handle agent updates via gRPC, includes EditData struct definition |
| internal/agent/agent.go | Added public Edit method to expose editAgent functionality |
| cmd/agent/edit.go | New CLI command implementation with flags for agent editing, includes config file support and validation |
| cmd/agent/agent.go | Registered the new edit command with the agent command group |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.