-
Notifications
You must be signed in to change notification settings - Fork 6
add scopes supported entry to protected resource metadata route #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add scopes supported entry to protected resource metadata route #11
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No high-severity issues spotted; scopes metadata addition looks consistent with other endpoints.
Signed-off-by: Zhong Liang Ong <zong@liftoff.io>
392923f to
bfcaab6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good—no issues found in this change.
| "resource_documentation": fmt.Sprintf("%s/docs", h.config.MCPURL), | ||
| "resource_policy_uri": fmt.Sprintf("%s/policy", h.config.MCPURL), | ||
| "resource_tos_uri": fmt.Sprintf("%s/tos", h.config.MCPURL), | ||
| "scopes_supported": []string{"openid", "profile", "email"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat pick, can it be configurable through env as well?
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.