-
Notifications
You must be signed in to change notification settings - Fork 29
ci/build-deb: Don't merge main #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
When building Debian packages from the branch of a PR, we want to actually build what's on the branch, without changes from main. That's especially important when preparing bugfix releases, which we build from the source packages from the CI. We don't want unexpected changes from main to end up in these releases.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
=======================================
Coverage 85.65% 85.65%
=======================================
Files 82 82
Lines 5794 5794
Branches 111 111
=======================================
Hits 4963 4963
Misses 775 775
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3v1n0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, github actions syntax is crazy 😭, but that's good.
It shouldn't still cause anything else for main, so good.
|
do you agree that we still want this PR, even though for releases we can use the artifacts built from the tag? my reasoning is that it's still unexpected that the debian packages built for a PR contain changes from main which are not in the PR branch. |
|
Well, there are pro and cons... Like in this way we can test what would be once merged, otherwise it's also true that one can just rebase... So indeed this gives more freedom of choice. |
When building Debian packages from the branch of a PR, we want to actually build what's on the branch, without changes from main.
That's especially important when preparing bugfix releases, which we build from the source packages from the CI. We don't want unexpected changes from main to end up in these releases.