Story/iexp 591 #860
Closed
Story/iexp 591 #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checked for publication date attribute existence
…raph data more typical of production database
jdamerow
requested changes
Nov 20, 2025
| node_ids = set(display_subjects.copy()) | ||
|
|
||
| if concept_or_geographic_subject_authority_ids: | ||
| concept_or_geographic_related_citation_ids = ACRelation.objects.filter( |
Member
There was a problem hiding this comment.
this needs to be initialized or line 42 will throw an error if this if is not executed.
Member
Author
There was a problem hiding this comment.
i'm not sure what you mean by this
Member
There was a problem hiding this comment.
if concept_or_geographic_subject_authority_ids = False, then line 34 will not be executed and line 42 (if concept_or_geographic_related_citation_ids:) will throw and error because there is no variable concept_or_geographic_related_citation_ids.
| .values_list("authority__id", flat=True)[:299] | ||
|
|
||
| if concept_or_geographic_related_authors: | ||
| display_subjects.update(concept_or_geographic_related_authors) |
Member
There was a problem hiding this comment.
all of the above code needs comments about what this is trying to achieve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.