Rm error priority

[FidelSch]

When rm would error out for several different reasons, it used to follow a different ordering than GNU. Eg. if you ran coreutils rm -d . on a non-empty dir, it would complain "Refusing to remove '.'" while GNU would show "Directory not empty".

It should now follow a similar order to what GNU shows. (Is directory > Dir not empty > preserve-root > current/parent directory)

[codspeed-hq]

CodSpeed Performance Report

Merging #9827 will not alter performance

_{Comparing FidelSch:rm-error-priority (ffd3e1c) with main (a4701f4)}

Summary

✅ 127 untouched
⏩ 6 skipped¹

Footnotes

1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

[sylvestre]

i am curious, how did you identify this issue? thanks

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

[FidelSch]

#9749 Sparked my curiosity, so I just tried different combinations that would fail in several ways such as the mentioned rm -d . or rm dir/ on non-empty dir

[sylvestre]

please fix the failing jobs