Skip to content

Conversation

@mattsu2020
Copy link
Contributor

Implement NumericLocaleSettings to handle thousands separators and decimal points based on locale. Update tokenization logic to accommodate blank thousands separators for numeric and human-numeric modes, ensuring proper parsing of numbers with locale-specific formatting. This enhances compatibility with international number representations.

Implement NumericLocaleSettings to handle thousands separators and decimal points based on locale. Update tokenization logic to accommodate blank thousands separators for numeric and human-numeric modes, ensuring proper parsing of numbers with locale-specific formatting. This enhances compatibility with international number representations.
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 25, 2025

CodSpeed Performance Report

Merging #9848 will degrade performance by 3.4%

Comparing mattsu2020:sort_sort-h-thousands-sep.sh (d4e80d2) with main (3e71f63)

Summary

❌ 1 regression
✅ 126 untouched
⏩ 6 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
sort_numeric 23.9 ms 24.7 ms -3.4%

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-h-thousands-sep is no longer failing!
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

Replace default initialization followed by assignment with struct syntax for clarity and to avoid intermediate mutation.
- Updated the spell-checker ignore comment in sort.rs to include "localeconv",
  preventing false positives for this technical term likely used in locale-related code.
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-h-thousands-sep is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant