feat(manifest): add assets field for standalone CSS entry points
#21015
+37
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manifest.json file lists imported assets and CSS files per entry point, so the back end code can generate corresponding `<link rel=preload>` and `<link rel=stylesheet>`. These two manifest properties were missing for pure CSS entry points, if they weren't included by some other JavaScript entry point. See: vitejs#18392 (comment)
sapphi-red
reviewed
Oct 28, 2025
sapphi-red
added
p2-nice-to-have
sapphi-red
changed the title
assets field for standalone CSS entry points
Contributor
Author
…nks only (vitejs#21136)") into bugfix/imported-assets-dropped-for-standalone-pure-css-entry-points
Contributor
Author
|
I tried a quick update of this branch to v8.0.0-beta.1 but couldn't get it working yet. I found the I only pushed the conflict resolution for the docs for now and converted the PR to Draft since it doesn't work on version 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manifest.json file lists imported assets and CSS files per entry point, so the back end code can generate corresponding
<link rel=preload>and<link rel=stylesheet>. These two manifest properties were missing for pure CSS entry points, if they weren't included by some other JavaScript entry point.See: #18392 (comment)