Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3013, which was closed because I deleted my old account.
🍰 Pullrequest
Adjust the algorithm for waypoint movement similar to CMaNGOS:
This prevents the animation resets occuring at each waypoint.
Issues
Closes #2713
How2Test
Watch different creatures which use waypoint movement, e.g.:
Also watch creature formations without waypoint movement, e.g. Emeraldon Boughguard (GUID 33246, ID 12474).
Sometimes there are small "jumps" visible while the NPC follows its path, example:
https://github.com/user-attachments/assets/221bbc42-1844-428f-92bb-bbf1c689cc4d
This is not related to this PR, it is caused by the client using low precision linear splines (3 float values packed into one integer value) and the server using high precision. The low precision linear spline coordinates are generated here for the client:
core/src/game/Movement/spline/packet_builder.cpp
Line 108 in 82edaee