-
Notifications
You must be signed in to change notification settings - Fork 9
398 alignment with bfo #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
|
Alignment of I'm comfortable that this set of alignments is OK now. |
|
@ldesousa I checked to see if the CCO URIs dereference - I'm finding that they pull down TTL representations quite nicely The BFO ones go to Ontobee or OLS, except for http://purl.obolibrary.org/obo/BFO_0000057 (has participant) which is failing. I've reported it here BFO-ontology/BFO-2020#154 |
|
@dr-shorthair Did a first quick browse. I noticed Generation, Usage, and Invalidation are subclass of Instantaneous Event, which looked suspicious. you don't need When you write something like |
|
Thanks @alanruttenberg . I think your comment relates to the PROV-BFO alignment from the Nature Scientific Data paper - Figure 2, where PROV Influence is shown. We aren't responsible for that work. I just used it to provide some perspectives, since we had already aligned SSN with PROV in the 2017 edition of SSN. What we request now is a review of the direct alignment of SSN to BFO/CCO which can be inspected in draft tabulated here and in the RDF (Turtle) representation here |
|
Please note that I have erred on the generalized side in the BFO/CCO hierarchy, and @alanruttenberg may suggest some tighter alignments for e.g. sosa:Sample. |
Use mouseover definitions for BFO/CCO
# Conflicts: # ssn/chapters/Modularization.html # ssn/images/SSN-alignment-modules.svg
maximelefrancois86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor changes:
in html:
- order in section 4.3 is not the same as in section 7
- the alignment of Property to Quality forces Properties to be "foi specific" (see examples). I think we should open up the alignment to BFO19 (Quality) OR BFO31 (generically dependent continuent)
- sosa
:implementscannot be aligned to BFO34 (function), which is a class - can't find any object property in the version of BFO I found. and BFO55 (realizes) and BFO57 (has participant) don't dereference
- change/define style for explanation span next to rhs ? (monospaced font not justified, as the text is not part of the concept CURIE)
|
Thanks @maximelefrancois86 - I've fixed all of these except the alignment of @alanruttenberg do you have any suggestions for this? |
# Conflicts: # ssn/index.html
|
I have suggested alignment of I think this now clears all the concerns raised by @maximelefrancois86 Preview https://raw.githack.com/w3c/sdw-sosa-ssn/398-alignment-with-bfo/ssn/index.html#BFO-alignment |
make Procedure alignment to Descriptive Information Content Entity 9rather than its more general superclass.
|
Please review this PR @maximelefrancois86 @kjano @ldesousa @oldskeptic |
Closes #398
Preview https://raw.githack.com/w3c/sdw-sosa-ssn/398-alignment-with-bfo/ssn/index.html#BFO-alignment