Skip to content

Conversation

@oldskeptic
Copy link
Contributor

This refactors the long ACME Brewery according to all the changes in SOSA and follows the new file layout.

@dr-shorthair
Copy link
Collaborator

@dr-shorthair
Copy link
Collaborator

C.1.1 Packaging and initial storage

  1. Is <acmePorterSixPack> an individual or a class?
    In the first mention <acmePorterSixPack> a beer:Porter, gs1:Product, schema:Product . it is an individual, unless beer:Porter, gs1:Product, schema:Product are sub-classes (rather than instances) of owl:Class. But a few lines lower down <10/PO202402/21/0001/acmePorterSixPack> rdfs:subClassOf <acmePorterSixPack> . it behaves like a class.
  2. It looks like you reused the classes from 8.12 Complex devices e.g. sensor:IBS-TH2-Plus-H - good! However, you have tied <12345/HumiditySensor> and <12345/TemperatureSensor> to <12345/someTH2> using sosa:hosts which makes latter a Platform. In 8.12 Complex devices it is a System with sub-systems.
  3. Could <00001/packingSixPack> be modeled as a sosa:Deployment, either in addition to or instead of prov:Activity?

Copy link
Contributor

@maximelefrancois86 maximelefrancois86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken Fig 52 ?

@oldskeptic
Copy link
Contributor Author

  1. Is <acmePorterSixPack> an individual or a class?
    In the first mention <acmePorterSixPack> a beer:Porter, gs1:Product, schema:Product . it is an individual, unless beer:Porter, gs1:Product, schema:Product are sub-classes (rather than instances) of owl:Class. But a few lines
    lower down <10/PO202402/21/0001/acmePorterSixPack> rdfs:subClassOf <acmePorterSixPack> . it behaves like a class.

Both. This is a untidy corner of both schema.org and gs1 product. In Page 115 of the GS1 Digital Link Standard, it must be a class because of the relationships between lots / serial numbers. It's an instance of schema:IndividualProduct in schema.org land. The problem is also reviewed in gs1/WebVoc#38. I'm comfortable leaving it as both in this particular example, I added a schema:IndividualProduct type to make the distinction clear.

Commercial implementation (me) run into this issue every day. Do you think that a short explanatory blurb would be beneficial in the long example?

  1. It looks like you reused the classes from 8.12 Complex devices e.g. sensor:IBS-TH2-Plus-H - good! However, you have tied <12345/HumiditySensor> and <12345/TemperatureSensor> to <12345/someTH2> using sosa:hosts which makes latter a Platform. In 8.12 Complex devices it is a System with sub-systems.

Fixed.

  1. Could <00001/packingSixPack> be modeled as a sosa:Deployment, either in addition to or instead of prov:Activity?

A version of this is done in "C.1.4.1 Recording data and sensor tasking through sensor deployments".

@oldskeptic
Copy link
Contributor Author

broken Fig 52 ?

It's rendering properly locally here. What breakage are you seeing?

@oldskeptic oldskeptic requested a review from sgrellet November 28, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants