-
Notifications
You must be signed in to change notification settings - Fork 9
Rebuilt long beer example. #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
|
C.1.1 Packaging and initial storage
|
maximelefrancois86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken Fig 52 ?
Both. This is a untidy corner of both schema.org and gs1 product. In Page 115 of the GS1 Digital Link Standard, it must be a class because of the relationships between lots / serial numbers. It's an instance of schema:IndividualProduct in schema.org land. The problem is also reviewed in gs1/WebVoc#38. I'm comfortable leaving it as both in this particular example, I added a schema:IndividualProduct type to make the distinction clear. Commercial implementation (me) run into this issue every day. Do you think that a short explanatory blurb would be beneficial in the long example?
Fixed.
A version of this is done in "C.1.4.1 Recording data and sensor tasking through sensor deployments". |
It's rendering properly locally here. What breakage are you seeing? |
This refactors the long ACME Brewery according to all the changes in SOSA and follows the new file layout.