This repository was archived by the owner on Dec 1, 2023. It is now read-only.
Run specs against real redis as well; refactor Action's scope #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 5, 2017 16:04
* refactored Action class-level methods * got rid of a horrendous class level variable * derive default action scope from the class name * flush redis db before each test. * clean up gemspec * bump version to 0.3.0
|
@kigster : Travis fails on 1.9.3
Thoughts on supporting anything less than 2.2? |
Contributor
Author
|
I am happy to drop 1.9.3 if you guys are :) |
added 2 commits
January 10, 2017 13:18
The issue I faced is a race condition when two processes increment at the same time; first one performs zrem on two old elements, second does not have any elements to zrem (even though zcard > value) was satisified. This race condition must be simply coded around.
|
Looks good to @mattcamuto and I. @kigster Should we try to do some real redis tests in travis? |
Contributor
Author
|
We do on this branch! Check out |
- together with tests - updating gems, removing unused gems - migrating gem to /kigster for maintenance - bump version to 0.4.0
- also adding CodeCimate, new tests - updating README - version bump 0.4.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using Pause on a project, and I was getting an error that seemed like a redis error. Without being able to run specs against a real redis server, it was impossible to tell if the problem was with the gem or somewhere else.
Now the entire spec suite can run using
fakeredis(the default), and against a local redis instance.To access integration tests, run
rake spec:integrationinstead ofrake spec.Additionally, refactored the
Pause::Actionto stop using a class variable, which are considered harmful.Updated Travis config to run against ruby 2.4.0, and to run both test suites.