Skip to content

Conversation

@wardbox
Copy link
Owner

@wardbox wardbox commented Dec 2, 2025

Integration tests require Spotify API credentials which aren't available in the publish workflow. Only run unit tests.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the publish workflow to execute only unit tests, excluding integration tests that require external API credentials during the publishing process.

✏️ Tip: You can customize this high-level summary in your review settings.

Integration tests require Spotify API credentials which aren't
available in the publish workflow. Only run unit tests.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR modifies the GitHub Actions publish workflow to run only the specific unit test script (Spotishell.Tests.ps1) instead of executing all tests. A comment is added explaining that integration tests are excluded due to required API credentials. Other workflow configurations remain unchanged.

Changes

Cohort / File(s) Summary
GitHub Actions publish workflow
.github/workflows/publish.yml
Updated $config.Run.Path to run only the Spotishell.Tests.ps1 unit test script instead of all tests; added comment documenting exclusion of integration tests due to API credential requirements

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the test script path (Spotishell.Tests.ps1) is correct and exists
  • Confirm the comment accurately explains the integration test exclusion rationale
  • Check that the workflow still functions correctly with the modified test path

Possibly related PRs

  • CI/CD setup, deprecate appveyor #60: Modifies the same .github/workflows/publish.yml file to add test-run steps in the publish workflow, directly overlapping with the test configuration changes in this PR

Poem

🐰 A rabbit hops through workflows bright,
Skipping integration tests with might,
Unit tests run with focused care,
No API creds? No problem there!
Testing's cleaner, lean and tight! ✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c3b92a and 9c0a5c3.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@wardbox wardbox merged commit 1bde713 into main Dec 2, 2025
5 of 6 checks passed
@wardbox wardbox deleted the fix/publish-exclude-integration-tests branch December 2, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants