Optimize VectorQuantizeTask min/max finding with single-pass algorithm #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
quantizeToUint8andquantizeToUint16methods used spread operators withMath.min(...values)andMath.max(...values), causing performance degradation and potential stack overflow on large vectors.Changes:
findMinMax()helper that computes min/max in single pass using explicit loopquantizeToUint8andquantizeToUint16to use optimized helper{ min: 0, max: 1 }to prevent division by zeroBefore:
After:
Addresses feedback: #154 (comment)
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.