fix: improve URL validation in signOut redirect logic #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace simple string-based URL checking with proper URL parsing using the URL constructor. This provides more robust validation of internal vs external redirects during the sign-out flow. The previous approach checked if the location started with 'http' and didn't contain the current host, which could fail for edge cases like relative URLs or malformed URLs. The new implementation: - Uses URL constructor to properly parse redirect locations - Handles relative paths with try/catch fallback - More accurately distinguishes between same-origin and cross-origin redirects This ensures TanStack Router navigation is used for internal routes while full page navigation is used for external OAuth/logout URLs. Fixes workos#19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace simple string-based URL checking with proper URL parsing using the URL constructor. This provides more robust validation of internal vs external redirects during the sign-out flow.
The previous approach checked if the location started with 'http' and didn't contain the current host, which could fail for edge cases like relative URLs or malformed URLs. The new implementation:
This ensures TanStack Router navigation is used for internal routes while full page navigation is used for external OAuth/logout URLs.
Fixes #19