Laravel 11.x Compatibility

[laravel-shift]

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

• Checkout the l11-compatibility branch
• Review all comments for additional changes
• Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

[laravel-shift]

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/graphlint.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "worksome/graphlint": "dev-l11-compatibility",
    }
}

Finally, run: composer update

[spawnia]

Hi @owenvoke. We are using this package (thanks!) and would appreciate if you could take a look at making it Laravel 11 compatible.

[owenvoke]

Hey @spawnia, I'd completely missed this package. Just checking to make sure everything appears to work correctly with the changes. 👍🏻 So, looks like the current issue is that symplify/easy-testing was deprecated, and the tests needs to be rewritten here so that that package can be dropped.

Looks like symplify/autowire-array-parameter and symplify/package-builder (used for the console diff output) were also deprecated, so that logic will require rewriting too.

Regarding Easy Testing, that should be fairly easy as we can migrate to Pest's native snapshot testing (now done). The others, I'll need to look into further.

[spawnia]

Right, I still get the following error when trying to install from the Laravel Shift fork:

  Problem 1
    - Root composer.json requires worksome/graphlint dev-l11-compatibility || dev-todo-revert-to-stable-after-https://github.com/worksome/graphlint/pull/36 -> satisfiable by worksome/graphlint[dev-l11-compatibility].
    - Conclusion: don't install laravel/framework v11.0.2 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.0.3 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.0.4 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.0.5 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.0.6 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.0.7 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.0.8 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.1.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.1.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.2.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.3.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.3.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.4.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.5.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v11.0.1 (conflict analysis result)
    - worksome/graphlint dev-l11-compatibility requires symplify/package-builder ^11.3 -> satisfiable by symplify/package-builder[11.3.0, 11.3.1, 11.3.2].
    - symplify/package-builder 11.3.1 requires symfony/finder ^6.2 -> satisfiable by symfony/finder[v6.2.0, ..., v6.4.0].
    - symplify/package-builder 11.3.2 requires symfony/http-kernel ^6.2 -> satisfiable by symfony/http-kernel[v6.2.0, ..., v6.4.6].
    - symplify/package-builder[11.2.0, ..., 11.3.0] require symfony/dependency-injection 6.1.* -> satisfiable by symfony/dependency-injection[v6.1.0, ..., v6.1.12].
    - You can only install one version of a package, so only one of these can be installed: symfony/finder[v3.2.0, ..., v3.4.47, v4.0.0, ..., v4.4.44, v5.0.0, ..., v5.4.35, v6.0.0, ..., v6.4.0, v7.0.0].   
    - You can only install one version of a package, so only one of these can be installed: symfony/http-kernel[v4.0.0, ..., v4.4.51, v5.0.0, ..., v5.4.38, v6.0.0, ..., v6.4.6, v7.0.0, ..., v7.0.6].       
    - symfony/mailer[v7.0.0, ..., v7.0.6] conflict with symfony/http-kernel v6.3.12.
    - symfony/mailer[v7.0.0, ..., v7.0.6] conflict with symfony/http-kernel v6.3.3.
    - symfony/mailer[v7.0.0, ..., v7.0.6] conflict with symfony/http-kernel v6.2.14.
    - symfony/mailer[v7.0.0, ..., v7.0.6] conflict with symfony/http-kernel v6.2.6.
    - symfony/routing[v7.0.0, ..., v7.0.6] conflict with symfony/dependency-injection v6.1.12.
    - laravel/framework v11.0.0 requires symfony/finder ^7.0 -> satisfiable by symfony/finder[v7.0.0].
    - laravel/framework v11.0.0 requires symfony/http-kernel ^7.0 -> satisfiable by symfony/http-kernel[v7.0.0, ..., v7.0.6].
    - laravel/framework v11.0.0 requires symfony/mailer ^7.0 -> satisfiable by symfony/mailer[v7.0.0, ..., v7.0.6].
    - laravel/framework v11.0.0 requires symfony/routing ^7.0 -> satisfiable by symfony/routing[v7.0.0, ..., v7.0.6].
    - Root composer.json requires laravel/framework ^11 -> satisfiable by laravel/framework[v11.0.0, ..., v11.5.0].

Thanks for tackling this issue!

[owenvoke]

Just wanted to provide an update on this, I'm hopefully going to try to invest some time into handling this. But for now, we have opted to just download using composer global require worksome/graphlint on CI, rather than installing it in the project. This isn't ideal, but it's allowed us to upgrade to Laravel 11 without this being a blocker.

[owenvoke]

Going to try and pick this back up, as the composer global require hack doesn't work with PHP 8.4 due to nette/utils:^3 being required by symplify/autowire-array-parameter

The main thing left for this is to remove symplify/autowire-array-parameter, and migrate to another alternative (I guess probably a container such as Laravel's).

I've split the Easy Testing changes I made here into #47, to keep this related only to the Laravel 11 upgrade.