More generics #1123
More generics #1123
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @Override | ||
| public String print() { | ||
| return ""; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isEqualTo(ILconst other) { | ||
| return false; |
There was a problem hiding this comment.
The new ILconstTypeRef always returns an empty string from print() and false from isEqualTo(...) (lines 16‑23), so any compile‑time evaluation that produces an ImTypeRef will yield a constant that can never compare equal even when the underlying class types match. This breaks basic semantics for expressions that compare or store type references (e.g. type‑keyed maps or equality checks in compile‑time functions) and will cause all such comparisons to return false. It should compare the wrapped ImClassType and render a meaningful value instead of hard‑coding failure.
Useful? React with 👍 / 👎.
No description provided.