Skip to content

Upload reports to codecov #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
funivan merged 4 commits into from
Feb 8, 2025
Merged

Upload reports to codecov #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e39eebe
Upload reports to codecov
funivan Feb 8, 2025
8164108
Fix code style
funivan Feb 8, 2025
b453e33
Update changelog
funivan Feb 8, 2025
67c5b19
Add support for ElementFinder 3.0
funivan Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
include:
- php-version: '8.2'
composer-flag: '--prefer-lowest'
main: true
- php-version: '8.2'
composer-flag: ''
- php-version: '8.3'
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Changelog
All Notable changes to `Parser` will be documented in this file
## 3.0.0 [Unreleased]
## 3.0.0 [2025-02-08]
- Minimum required php version is now php 8.2

## 2.0.0 [2024-01-11]
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"guzzlehttp/guzzle": "^6.3 || ^7.3",
"guzzlehttp/psr7": "^2.4.5",
"psr/http-message": "^1.0 || ^2.0",
"xparse/element-finder": "^2.0"
"xparse/element-finder": "^2.0 || ^3.0"
},
"require-dev": {
"ext-iconv": "*",
Expand Down
3 changes: 1 addition & 2 deletions src/Helper/ToUtfConverter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
*/
class ToUtfConverter implements EncodingConverterInterface
{

private const EXCLUDED_ENCODINGS = [
"utf-8",
"utf8",
Expand Down Expand Up @@ -50,7 +49,7 @@ private function getSupportedEncodings(): array
$findAliases = function_exists('mb_encoding_aliases');
foreach (mb_list_encodings() as $encoding) {
$encoding = mb_strtolower($encoding);
if (!in_array($encoding, self::EXCLUDED_ENCODINGS)) {
if (! in_array($encoding, self::EXCLUDED_ENCODINGS)) {
$this->supportedEncodings[] = $encoding;
if ($findAliases) {
foreach (mb_encoding_aliases($encoding) as $encodingAlias) {
Expand Down