TPSA in Xsuite Matching (Interface to MAD-NG) #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport for full twiss matching (only without tpsa yet, coming soon)
babreufig
changed the title
Contributor
Author
|
Functionality is ready. Needs follow-up because new MAD-NG version breaks two tests that rely on calculating chromaticities, as phix/phiy in MAD-NG 1.1.8 changed by a factor 2. This can be found in this commit (MethodicalAcceleratorDesign/MAD-NG@5c87e03) @giadarol |
babreufig
changed the title
szymonlopaciuk
requested changes
Dec 16, 2025
Collaborator
szymonlopaciuk
left a comment
szymonlopaciuk
left a comment
There was a problem hiding this comment.
Good job, it's quite well structured and readable!
Some requests/comments/questions/suggestions for your consideration.
szymonlopaciuk
approved these changes
Dec 17, 2025
Collaborator
szymonlopaciuk
left a comment
szymonlopaciuk
left a comment
There was a problem hiding this comment.
Good for me, just the little comment.
Contributor
Author
|
New MAD-NG Version has been released, the related tests pass now! We could now pin the new version and this is then mergeable @szymonlopaciuk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements MAD-NG TPSA Action to use MAD-NG tracked damaps to acquire optical parameters.
This pull request requires at least MAD-NG version 1.1.8. There is a discrepancy in the chromaticity calculation between MAD-NG version 1.1.7 and 1.1.8, where the
phixis by a factor 2 smaller in the new version. This seems to be a different convention(?). Needs a follow-up because this affects Ax/Bx/Ay/By functions which are then different between Xsuite and MAD-NG. For reference: MethodicalAcceleratorDesign/MAD-NG@5c87e03Given the revert from the chromaticity bug, this pull request should be shipped with MAD-NG version 1.1.9!
Important: Depends on xsuite/xdeps#106
Mandatory: