Fix undefined name errors in enum models and add comprehensive CI/CD workflow #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The package had 7 critical F821 linting errors where enum model classes were using forward references to themselves in type annotations before the class definition was complete. Additionally, the GitHub Actions workflow needed enhancements to properly test the package and ensure quality.
Changes
Fixed Type Annotation Errors
Added
from __future__ import annotationsto 7 enum model files to enable forward references:cfbd/models/division_classification.pycfbd/models/game_status.pycfbd/models/media_type.pycfbd/models/recruit_classification.pycfbd/models/season_type.pycfbd/models/season_type_db.pycfbd/models/transfer_eligibility.pyThis allows the
from_json()class methods to properly reference their own class type in return annotations without triggering undefined name errors.Before:
After:
Enhanced CI/CD Workflow
Updated
.github/workflows/python-package.ymlto:test-requirements.txtin addition torequirements.txtsetup-python@v5for better performanceAdded Documentation & Examples
Created comprehensive documentation to help users and contributors:
Testing
All changes have been validated:
Benefits
This PR makes the package production-ready by:
The package can now be confidently installed, tested, and used in production environments.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.collegefootballdata.compython examples/basic_usage.py(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.