utils: Always print status to stderr #1905
Open
+45
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly redirects spinner status messages to stderr, preventing them from corrupting JSON output on stdout. The changes in the Rust code are logical, and the updated test case is a significant improvement, effectively verifying the fix. I've included a couple of suggestions to enhance the robustness of both the application code and the test script.
Collaborator
|
We might hitting an grub2 regression injected in fedora-bootc:44 |
This was referenced Jan 14, 2026
jeckersb
approved these changes
Jan 14, 2026
If we were waiting on a lock as part of `bootc status --format=json` this information message would end up in stderr, corrupting the output. Signed-off-by: Colin Walters <walters@verbum.org>
jeckersb
force-pushed
the
status-progress-json
branch
from
3fd0b4e to
4d5f8de
Compare
Collaborator
|
Rebased to pick up #1908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we were waiting on a lock as part of
bootc status --format=jsonthis information message would end up in stderr, corrupting the output.