Whitelist with nonexisting canonical domain #5935
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…norepo into whitelist-with-nonexisting-canonical-domain
prathmeshkhandelwal1
requested review from
LayneHaber,
liu-zhipeng and
preethamr
as code owners
just-a-node
reviewed
Mar 29, 2024
| }, | ||
| }, | ||
| { | ||
| // TODO: This is the old config, to be removed in execution layer upgrade |
Collaborator
There was a problem hiding this comment.
Keep this for reference, just comment out.
just-a-node
reviewed
Mar 29, 2024
| `\n\tVerifying asset setup for ${asset.name} (${asset.canonical.address}). Canonical ID: ${canonical.id}; Canonical Domain: ${canonical.domain}; Key: ${key}`, | ||
| ); | ||
|
|
||
| // Set up the canonical asset on the canonical domain. |
Collaborator
There was a problem hiding this comment.
This setup script needs to be able to register xERC20s using the pseudo-canonical domain as well as maintain the ability to register other assets that are homed on Eth. I don't think we can just remove the home checks, we should still have those guards.
We need to separate logic based on whether 11111 is specifically set as the canonical domain for an asset. If not, then the original checks should still apply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Fixes
Related pull request(s)