Skip to content

Modernize #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rickhull wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Modernize #2

rickhull wants to merge 31 commits into from

Conversation

@rickhull
Copy link

@rickhull rickhull commented Oct 31, 2017

It's likely some of these changes are controversial. In particular:

  • switch from test/unit to minitest/test
  • drop Gemfile
  • explicit self.instance_method calls

These changes can be easily reverted after the fact or omitted if they aren't desirable.

Top 5 enhancements:

  • Add benchmark/ips for some performance numbers
  • Fixed warnings
  • Stop fiddling with load path
  • Simpler code (fewer ivars and methods)
  • Better performance

There are other PRs (coming) with additional enhancements

rickhull added 30 commits October 31, 2017 05:32
@rickhull
add benchmark/ips: 460 ips
70bb0c9
@rickhull
use t.pattern and enable warnings
e48c7ec
@rickhull
stop manipulating load path in code
15c85ce
@rickhull
fix warnings about unused locals
d53f7d9
@rickhull
fix warnings about unused or shadow local vars
b88eab0
@rickhull
remove trailing whitespace
60b2edf
@rickhull
convert from test/unit to minitest/test
7ee8a0d
@rickhull
remove unused Simplex#assert; add comments
38b20c4
@rickhull
drop @pivot_count
5dfc795
@rickhull
simplify initalize; make @x an Array rather than Vector
7c35aa3
@rickhull
cleanup
e6db1c5
@rickhull
drop Simplex#variables and #replace_basic_variable
f5cb8eb
@rickhull
drop Gemfile and update travis
2449f22
@rickhull
rename to test/simplex.rb
919d784
@rickhull
drop #basic_variable_in_row
20a9484
@rickhull
use self.instance_method when calling instance methods
9f5f9a5
@rickhull
add comments
cadb517
@rickhull
cleanup; check for non-nil self.entering_variable
e6c420c
@rickhull
use self.instance method and fix some block parameters
3c3c2e7
@rickhull
TODO: investigate conditional
3516aae
@rickhull
drop #formatted_values
7950c49
@rickhull
make last_min_by a class method
19ab1ae
@rickhull
just call reject once
58b2f89
@rickhull
drop last_min_by
59b2ae9
@rickhull
drop #row_indices
11d7239
@rickhull
prefer @num_constraints to @a.size
a24525b
@rickhull
drop #column_indices
6f0e0a2
@rickhull
reorder some method definitions
20e81aa
@rickhull
Exceptions: add SanityCheck and TooManyPivots; inherit from RuntimeError
433c05c
@rickhull
introduce Simplex::Error and inherit from it
e1617c8
@rickhull rickhull mentioned this pull request Oct 31, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rickhull