fix: validate Connection header in IsWebSocket() [per RFC 6455] #2875
+21
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
IsWebSocket()function to properly validate WebSocket upgrade requests according to RFC 6455 specification.Problem
The current implementation only checks the
Upgradeheader but ignores theConnectionheader requirement specified in RFC 6455 Section 1.3. A valid WebSocket upgrade request must have both headers present with specific values.Solution
Updated
IsWebSocket()to validate both required headers:Upgrade: websocket(case-insensitive)Connection: upgrade(case-insensitive, may contain other values)Changes
IsWebSocket()incontext.goto check both headersTestContext_IsWebSocket()incontext_test.gowith additional test casesConnectionheaderTesting
All existing tests pass, including new test cases that verify:
ConnectionheaderConnection: closeRFC Reference
RFC 6455 - The WebSocket Protocol