Skip to content

fix: validate Connection header in IsWebSocket() [per RFC 6455] #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raju-mechatronics wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −3
Open

fix: validate Connection header in IsWebSocket() [per RFC 6455] #2875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a1dc4e
fix: add Connection header validation to IsWebSocket() (RFC 6455)
raju-mechatronics Jan 23, 2026
e67d43e
fix: enhance IsWebSocket() test cases with Connection header validation
raju-mechatronics Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,8 @@ func (c *context) IsTLS() bool {

func (c *context) IsWebSocket() bool {
upgrade := c.request.Header.Get(HeaderUpgrade)
return strings.EqualFold(upgrade, "websocket")
connection := c.request.Header.Get(HeaderConnection)
return strings.EqualFold(upgrade, "websocket") && strings.Contains(strings.ToLower(connection), "upgrade")
}

func (c *context) Scheme() string {
Expand Down
21 changes: 19 additions & 2 deletions context_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,15 +969,21 @@ func TestContext_IsWebSocket(t *testing.T) {
{
&context{
request: &http.Request{
Header: http.Header{HeaderUpgrade: []string{"websocket"}},
Header: http.Header{
HeaderUpgrade: []string{"websocket"},
HeaderConnection: []string{"upgrade"},
},
},
},
assert.True,
},
{
&context{
request: &http.Request{
Header: http.Header{HeaderUpgrade: []string{"Websocket"}},
Header: http.Header{
HeaderUpgrade: []string{"Websocket"},
HeaderConnection: []string{"Upgrade"},
},
},
},
assert.True,
Expand All @@ -996,6 +1002,17 @@ func TestContext_IsWebSocket(t *testing.T) {
},
assert.False,
},
{
&context{
request: &http.Request{
Header: http.Header{
HeaderUpgrade: []string{"websocket"},
HeaderConnection: []string{"close"},
},
},
},
assert.False,
},
}

for i, tt := range tests {
Expand Down