Fix record lookup when id is given as string #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given I have the following setup
Now, I have a route that updates all admins. I want to use the UserUpdater like this:
ActiveType doesn't use the given user array to locate the users and loads all given users seperately, causing far more database queries than needed. The issue seems to be that it checks all existing records for whether their id equals the id from the attributes hash. But the id in the loaded records is an integer, the id in the hash is a string, so they never equal.
This PR converts both the id of the existing record and the given id to a string before comparing. This should eliminate this error and will also work with string UUIDs.