Skip to content

Fix record lookup when id is given as string #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kratob merged 1 commit into from
Sep 11, 2025
Merged

Fix record lookup when id is given as string #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/active_type/nested_attributes/association.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def derive_class_name
end

def fetch_child(parent, id)
assigned = assigned_children(parent).detect { |r| r.id == id }
assigned = assigned_children(parent).detect { |r| r.id.to_s == id.to_s }
return assigned if assigned

if child = find_scope(parent).find_by_id(id)
Expand Down
13 changes: 13 additions & 0 deletions spec/active_type/nested_attributes_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,19 @@ def should_assign_and_persist(assign, persist = assign)
should_assign_and_persist(["existing 1", "updated", "existing 3"])
end

it 'allows the id to be given as a string' do
subject.records = [
NestedAttributesSpec::Record.new(:persisted_string => "existing 1"),
NestedAttributesSpec::Record.new(:persisted_string => "existing 2"),
]
subject.records[0].id = 100
subject.records[1].id = 101

subject.records_attributes = { '1' => { 'id' => '101', 'persisted_string' => 'updated' } }

should_assign_and_persist(["existing 1", "updated"])
end

it 'does not update records matching a reject_if proc' do
extra_options.merge!(:reject_if => :bad)
subject.records = [
Expand Down